Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product CSV outlet tax showing blank for exclusive #12

Open
jtrotsky opened this issue Mar 4, 2015 · 3 comments
Open

Product CSV outlet tax showing blank for exclusive #12

jtrotsky opened this issue Mar 4, 2015 · 3 comments

Comments

@jtrotsky
Copy link

jtrotsky commented Mar 4, 2015

It looks like the outlet_tax for each outlet is showing blank.
If the outlet_tax is just the outlet default then it should show Default tax, otherwise it should show the specific outlet tax.

@pulkitsinghal
Copy link
Contributor

This was intentional thus far and I would like to get you opinion on how to solve the following challenge:

    "taxes": [
      {
        "outlet_id": "yyy",
        "tax_id": "zzz"
      },
    ]

If a retailer has 9000 products, given the structure of taxes array inside a product response ... it requires a lookup to get the names, that means a whole bunch of lookups and with the api rate limiting I think the report may never finish!

But hmmm.... if I just fetch all the taxes in advance then its just one extra pre-emptive api call isn't it? You know what ... on second thought this may be feasible!

@pulkitsinghal
Copy link
Contributor

@jtrotsky - Can you help me out and paste some data or snapshot of what it looks like when the value won't be Default tax ... does it use the tax name, or tax id or the actual tax numerical value?

@jtrotsky
Copy link
Author

jtrotsky commented Mar 4, 2015

Hi @pulkitsinghal ,

It uses the tax name.

/api/taxes :

taxes: [
{
id: "b8ca3a65-0109-11e4-fbb5-5d6838e3db38",
name: "AU GST",
rate: 0.1,
default: false,
active: true,
rates: [
{
id: "38e3c309-5d68-11e4-9bb5-b8ca3a65011c",
rate: 0.1,
name: "AU GST"
}
]
}

The way I do it is to gather all the taxes from /api/taxes and then whilst writing the product info I go through each outlet and find the tax with default: true, if I find a match then I can put Default tax, otherwise I use the tax_name from the product.

It looks like this for a tax exclusive store with various taxes on different products/outlets:
(ignore the blanks, this is for composite product entries)

screenshot 2015-03-04 13 30 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants