Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove validation of API version #737

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Remove validation of API version #737

merged 1 commit into from
Oct 29, 2024

Conversation

lizkenyon
Copy link
Contributor

@lizkenyon lizkenyon commented Sep 24, 2024 •
edited
Loading

WHY are these changes introduced?

Allow the use of API versions that are not previously defined

WHAT is this pull request doing?

  • If the string passed in was not a previously defined release, make a new release on the fly

Checklist

  • I have updated the CHANGELOG (if applicable)
  • I have followed the Shopify Python guide

@lizkenyon lizkenyon force-pushed the liz/make-api-version-more-flexible branch 5 times, most recently from d228d8e to 12bbe8b Compare September 24, 2024 19:03
@lizkenyon
Make API version more flexible
fdc155e 
Allow the use of API versions that are not previsouly defined
@lizkenyon lizkenyon force-pushed the liz/make-api-version-more-flexible branch from 12bbe8b to fdc155e Compare September 24, 2024 19:06
@sle-c sle-c self-requested a review September 24, 2024 20:48
sle-c
sle-c approved these changes Sep 24, 2024
View reviewed changes
Copy link

@sle-c sle-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo still utilizes ActiveResource instead of generated resources like ruby so I think this approach works well

matteodepalo
matteodepalo approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@matteodepalo matteodepalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkham Arkham mentioned this pull request Oct 25, 2024
Closed
2 tasks
@tyzhnenko tyzhnenko mentioned this pull request Oct 25, 2024
Closed
1 task
@tyzhnenko
Copy link

Hey @paulomarg,

Please help with this PR.
When could it be merged?

TIA

@lizkenyon lizkenyon merged commit 06267b3 into main Oct 29, 2024
12 checks passed
@lizkenyon lizkenyon deleted the liz/make-api-version-more-flexible branch October 29, 2024 14:33
@tyzhnenko tyzhnenko mentioned this pull request Oct 29, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteodepalo matteodepalo matteodepalo approved these changes

@sle-c sle-c sle-c approved these changes

@SimonFranc SimonFranc SimonFranc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lizkenyon @tyzhnenko @matteodepalo @sle-c @SimonFranc