Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested Operations docs should be updated #56

Open
sambostock opened this issue Sep 1, 2020 · 0 comments
Open

Nested Operations docs should be updated #56

sambostock opened this issue Sep 1, 2020 · 0 comments

Comments

@sambostock
Copy link
Contributor

We include the following in README.md:

What do I do if each iteration takes a long time, because it's doing nested operations? If your each_iteration is complex, we recommend enqueuing another job, which will run your nested business logic. We may expose primitives in the future to do this more effectively, but this is not terribly common today. We recommend to read goo.gl/UobaaU to learn more about nested operations.

The link we provide is problematic for two reasons:

  • it links to our internal Discourse instance, despite this being a public repository
  • the answer explicitly directs the user to use BackgroundQueue.enqueue (as well as start_id: and last_id:) which is Shopify/shopify specific, even though JobIteration is used outside that repo

We should link to something public and non-Shopify specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant