Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Active Record 7.1+ whole table iteration #493

Open
bdewater opened this issue Jul 29, 2024 · 1 comment
Open

Consider Active Record 7.1+ whole table iteration #493

bdewater opened this issue Jul 29, 2024 · 1 comment

Comments

@bdewater
Copy link
Contributor

rails/rails#45414 introduced the use_ranges: true option which looks to iterate similarly to ActiveRecordCursor. If job-iteration switched over, it gets other improvements (e.g. descending order) as well.

@fatkodima
Copy link
Contributor

I think, the gem can switch to as simple activerecord-related iteration implementation as in https://github.com/sidekiq/sidekiq/blob/main/lib/sidekiq/job/iterable/active_record_enumerator.rb, given that the latest activerecord now implements all the features (like different orders, iterating over multiple columns etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants