Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobIteration::TestHelper should be refactored #461

Open
sambostock opened this issue Feb 9, 2024 · 0 comments
Open

JobIteration::TestHelper should be refactored #461

sambostock opened this issue Feb 9, 2024 · 0 comments

Comments

@sambostock
Copy link
Contributor

sambostock commented Feb 9, 2024

  • It's API is awkward by requiring an object responding to size instead of just taking in an Integer, despite the documentation saying it wants an Integer.
  • It stubs out the adapter globally, which probably won't work for per-job class adapters.
  • It requires adapter mutability, instead of using a smarter adapter that can be forced on or off.
  • It has an implicit dependency on mocha.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant