Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we instrument the reason for interruption? #247

Open
sambostock opened this issue Jul 5, 2022 · 0 comments
Open

Should we instrument the reason for interruption? #247

sambostock opened this issue Jul 5, 2022 · 0 comments

Comments

@sambostock
Copy link
Contributor

As per #240 (comment)

As a user of the library, it would be helpful if there was an easy way to get notified (as in ActiveSupport::Notifications.instrument) when a job is interrupted due to elapsing the max run time setting. For example, a user could track how many times this is happening per some application-level metric to tune the time out setting accordingly.

We already instrument interruption, but we do not capture the interruption reason. We could potentially do this in job_should_exit? and forward the value to the instrumentation. We could also consider having the interruption adapter return a string or symbol, rather than just a boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant