Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated passing null to strripos and rtrim with php 8.3 #428

Closed
sirber opened this issue Jun 20, 2024 · 6 comments
Closed

deprecated passing null to strripos and rtrim with php 8.3 #428

sirber opened this issue Jun 20, 2024 · 6 comments

Comments

@sirber
Copy link

sirber commented Jun 20, 2024

( ! ) Deprecated: strripos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /app/vendor/shardj/zf1-future/library/Zend/View/Helper/BaseUrl.php on line 110

( ! ) Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /app/vendor/shardj/zf1-future/library/Zend/View/Helper/BaseUrl.php on line 72

@sirber sirber changed the title deprecated strripos and rtrim with php 8.3 deprecated passing null to strripos and rtrim with php 8.3 Jun 20, 2024
@B3none
Copy link

B3none commented Aug 3, 2024

I checked the file, and it looks like these issues have been resolved: https://github.com/Shardj/zf1-future/blob/master/library/Zend/View/Helper/BaseUrl.php

When's the last time you ran a composer update?

@sirber
Copy link
Author

sirber commented Aug 3, 2024

I'm on the latest 1.24 version, still having those issues.

@B3none
Copy link

B3none commented Aug 3, 2024

I've got it running on 8.3.9 without any problems, can you give me an example snippet of what you're doing and I'll test it on my end.

Update:
Ah, looks like the fix is in master, but 1.24.0 doesn’t contain the latest code for that file.

@addison74
Copy link

A new release should be made public including this PR #442 for testing ZF1-Future with PHP 8.4.

@sirber
Copy link
Author

sirber commented Oct 15, 2024

Related to #450

@develart-projects
Copy link
Collaborator

released 1.24.1 with fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants