Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HammerJS depends on CommonJS - bailout warning #16

Closed
davidzwa opened this issue Aug 9, 2020 · 1 comment
Closed

HammerJS depends on CommonJS - bailout warning #16

davidzwa opened this issue Aug 9, 2020 · 1 comment

Comments

@davidzwa
Copy link
Collaborator

davidzwa commented Aug 9, 2020

As most of us now use Angular 10, they will have started to notice the new CommonJS bailout warning for libraries which dont uphold the standard. As HammerJS is a must for us, we can only provide the tip to suppress the warning.

@davidzwa
Copy link
Collaborator Author

davidzwa commented Aug 9, 2020

Added to readme

Known problems

  • HammerJS is known to give a CommonJS bailout warning for Angular 10 when compiling. To suppress this warning add the following to your angular.json:

projects:project-name-here:architect:build:options:allowedCommonJsDependencies: { ..., "hammerjs", ...}

or put differently, add hammerjs to allowedCommonJsDependencies for the @angular-devkit/build-angular:browser builder specification:

"allowedCommonJsDependencies": [
    "hammerjs"
],

@davidzwa davidzwa closed this as completed Aug 9, 2020
@davidzwa davidzwa pinned this issue Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant