Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up variables loading on world map page #97

Merged
merged 11 commits into from
Sep 19, 2024

Conversation

edwardchalstrey1
Copy link

@edwardchalstrey1 edwardchalstrey1 commented Sep 19, 2024

Closes #84

Refactors the map_view_all_with_vars to avoid loading all the geometries twice

TODO:

  • Try minimal shape id to seshat id mapping for variables func - did not increase speed further (see load-vars-separately-2)
  • Refactor common map view content?
  • Docstrings
  • There appears to be an un-noticed bug in that allCapitalsInfo is only being generated for the "variables" view but being set for the "all" view (where it is a blank dict) - for now we could set this to a blank dict in both but leave a comment with the capitals function to come back to later

@edwardchalstrey1 edwardchalstrey1 merged commit b3d7b8e into dev Sep 19, 2024
1 check passed
@edwardchalstrey1 edwardchalstrey1 deleted the load-vars-separately branch September 19, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Further loading speedups for Seshat website (especially maps)
1 participant