Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and extended for Magento 2.3.4... #31

Open
losttheplot opened this issue Feb 20, 2020 · 3 comments
Open

Fixed and extended for Magento 2.3.4... #31

losttheplot opened this issue Feb 20, 2020 · 3 comments

Comments

@losttheplot
Copy link

Having used this project a few years ago, and having been very grateful to Sebwite for making it available on github, I thought I would bring the latest master up-to-date and suitable for use with Magento 2.3.4. As I don't have time to learn about pull requests and the like, I am attaching my updated master here for anyone who might want to use it.

I have included all fixes mentioned in currently open issues, and have also added: (1) very basic functionality that means the 'enabled' config selector now works, (2) a new config option that allows the menu title to be set, (3) increased category depth option to 8, (4) small CSS changes to look better with the 2.3.4 Luma theme, and (4) a new config option and associated javascript code that automatically opens the menu to the active page (if enabled). I'm no expert, so feel free to improve or correct my work.

Sebwite.zip

@rlienhar
Copy link

Thanks for your conclusion of all the fixes, it works great with 2.3.4!
It would be great if your work were available in a new version to use Composer directly from the Github.

groomershop pushed a commit to groomershop/magento2-category-sidebar that referenced this issue Apr 13, 2020
@jtomaszewski
Copy link

jtomaszewski commented Apr 15, 2020

Hey @losttheplot , we submitted those changes at our fork in https://github.com/groomershop/magento2-category-sidebar .

You can use it directly by adding the following to composer.json:

    "require": {
        "sebwite/magento2-category-sidebar": "dev-master"
    },
    "repositories": {
        "magento2-category-sidebar": {
            "type": "vcs",
            "url": "[email protected]:groomershop/magento2-category-sidebar.git"
        },
    }

If anybody feels like using / improving that fork feel free to do so, we'll be using this module at our Magento for sure ;)

P.S. @losttheplot I assume the license for your code fixes is the same as the composer.json says (OSL / AFL) ?

@losttheplot
Copy link
Author

P.S. @losttheplot I assume the license for your code fixes is the same as the composer.json says (OSL / AFL) ?

Sure - glad to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants