-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No Children depth level option #19
Comments
@ameniconi you should be able to change line 222 in the Block/Sidebar.php file from
to
This worked for me. I'm going to open up a pull request to get this updated if this works for you. |
I have made following changes in line 105 Block/Sidebar.php |
Does not make sense to patch the extension -- would a PR to make this configurable be accepted? |
Actuall it is in master -- question is when it will be tagged https://github.com/Sebwite/magento2-category-sidebar/blob/master/Model/Config/Source/Depth.php Other question is: Why limiting depth to level 5 and not just accept an integer? |
Hello, I have the problem after installation, I see only category title, not categorya. Can someone help me? I change display:block , but it is dont work |
Thats dont working for me, I have no idea what is wrong. I see only
"category" tittle, without menu links.
www.nk-collection.de
Look, it s calls Kategorien in german, after this tittle is nothing
ср, 15 янв. 2020 г. в 18:35, Matt6 Studios, LLC <[email protected]>:
… @ameniconi <https://github.com/ameniconi> you should be able to change
line 222 in the Block/Sidebar.php file from
return $category->getChildrenCategories()
to
return $category->getChildren()
This worked for me. I'm going to open up a pull request to get this
updated if this works for you.
This worked for me too.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AF7GFNHNSBEKUZRHVU54CKTQ55CMPA5CNFSM4ECD6CZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBEVAQ#issuecomment-574769794>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7GFNHEHIWR6R3M3DTWYALQ55CMPANCNFSM4ECD6CZA>
.
|
If you check it out using your browsers development tools you will see .sidebar .o-list display is set to none. That is part of the problem. But even after I set that to display there isn't anything listed. So you might have some kind of setting not right in the admin. Making these changes it works for me and after changing code for the way I need it we should be good. |
Okay, I think I do changes on the wrong CSS file. I found this information
( see on the bottom of message)
Can you please tell me, where I can findet this module.css file?
Thank you for help!
Just find the file Sebwite_Sidebar/css/module.css And change the css
declaration
.sidebar .o-list { display: none; }
To
.sidebar .o-list { display: block; }
Matt6 Studios, LLC <[email protected]> schrieb am Mi., 15. Jan.
2020, 21:46:
… Thats dont working for me, I have no idea what is wrong. I see only
"category" tittle, without menu links. www.nk-collection.de Look, it s
calls Kategorien in german, after this tittle is nothing ср, 15 янв. 2020
г. в 18:35, Matt6 Studios, LLC ***@***.***:
… <#m_-4980759684684618568_>
@ameniconi <https://github.com/ameniconi> https://github.com/ameniconi
you should be able to change line 222 in the Block/Sidebar.php file from
return $category->getChildrenCategories() to return
$category->getChildren() This worked for me. I'm going to open up a pull
request to get this updated if this works for you. This worked for me too.
— You are receiving this because you commented. Reply to this email
directly, view it on GitHub <#19
<#19>?email_source=notifications&email_token=AF7GFNHNSBEKUZRHVU54CKTQ55CMPA5CNFSM4ECD6CZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBEVAQ#issuecomment-574769794>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF7GFNHEHIWR6R3M3DTWYALQ55CMPANCNFSM4ECD6CZA
.
If you check it out using your browsers development tools you will see
.sidebar .o-list display is set to none. That is part of the problem. But
even after I set that to display there isn't anything listed. So you might
have some kind of setting not right in the admin.
Making these changes it works for me and after changing code for the way I
need it we should be good.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AF7GFNBGW4NY6GIMK7YW3G3Q55Y35A5CNFSM4ECD6CZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJBX7II#issuecomment-574848929>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7GFNDDJJXQELCNW5ALWQDQ55Y35ANCNFSM4ECD6CZA>
.
|
This is a less file that gets compiles on the fly. You'll find it here: /view/frontend/web/css/ Stan |
Yes, that is the same file, where I do the changes. See screenshot
And after cleaning cache no result :(
Matt6 Studios, LLC <[email protected]> schrieb am Mi., 15. Jan.
2020, 22:23:
… Can you please tell me, where I can findet this module.css file?
This is a less file that gets compiles on the fly. You'll find it here:
/view/frontend/web/css/
Stan
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AF7GFNHLUQL2ZYX2VSIFKATQ555ETA5CNFSM4ECD6CZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJB3IOA#issuecomment-574862392>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7GFNH4XTD23437LMESHZLQ555ETANCNFSM4ECD6CZA>
.
|
Thank you very much for your help. I found the solution, that is the wrong
place to change css, the right file is in the pub directory in the actually
theme, there
/pub/static/frontend/Zemez/theme066/de_DE/Sebwite_Sidebar/css/module.css
Maybe you can add this solution to github
ср, 15 янв. 2020 г. в 22:37, Natalie Bansikov <[email protected]>:
… Yes, that is the same file, where I do the changes. See screenshot
And after cleaning cache no result :(
Matt6 Studios, LLC ***@***.***> schrieb am Mi., 15. Jan.
2020, 22:23:
> Can you please tell me, where I can findet this module.css file?
>
> This is a less file that gets compiles on the fly. You'll find it here:
>
> /view/frontend/web/css/
>
> Stan
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#19?email_source=notifications&email_token=AF7GFNHLUQL2ZYX2VSIFKATQ555ETA5CNFSM4ECD6CZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJB3IOA#issuecomment-574862392>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AF7GFNH4XTD23437LMESHZLQ555ETANCNFSM4ECD6CZA>
> .
>
|
Hi, That won't fix the problem permanently. The static folder will get overridden next time the files get re-generated. You have to change it where I listed, in the less file, and then run upgrade, di:compile and then deploy your static files. |
Can you please tell me the code, how I can run update with ssh? Sorry for
importunity, I'am newbe. It is very hard to do something without good
knowleges. I have some bugs with my page. Do you allow me to ask questions
by you?
Matt6 Studios, LLC <[email protected]> schrieb am Do., 16. Jan.
2020, 14:34:
… I found the solution, that is the wrong place to change css, the right
file is in the pub directory in the actually theme
Hi,
That won't fix the problem permanently. The static folder will get
overridden next time the files get re-generated. You have to change it
where I listed, in the less file, and then run upgrade, di:compile and then
deploy your static files.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19?email_source=notifications&email_token=AF7GFNGTV33VXLQ3NMNU42DQ6BO63A5CNFSM4ECD6CZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJECJDA#issuecomment-575153292>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF7GFNBC7XV3L6JUIECSOZDQ6BO63ANCNFSM4ECD6CZA>
.
|
Hi, Google is your friend. If you Google Magento 2 how to clean your cache using ssh you will find a lot of help. Here are a few to the Magento docs: https://devdocs.magento.com/guides/v2.3/config-guide/cli/config-cli-subcommands-cache.html Stan |
Installed this with composer, I can see the top level categories but no subcategories showing. Also no children depth level option to select in the admin config page, any advice?
The text was updated successfully, but these errors were encountered: