From 90da415a400f686fb17c836bdf4df6c3619b5bc3 Mon Sep 17 00:00:00 2001
From: ScuffedNewt <dragonminer101@gmail.com>
Date: Fri, 25 Oct 2024 16:20:18 +0100
Subject: [PATCH] fix: custom title

---
 app/Models/Character/CharacterImage.php      | 2 +-
 app/Models/Character/CharacterImageTitle.php | 2 +-
 app/Models/Character/CharacterTitle.php      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/Models/Character/CharacterImage.php b/app/Models/Character/CharacterImage.php
index f7b4bd2fa..a626b67dc 100644
--- a/app/Models/Character/CharacterImage.php
+++ b/app/Models/Character/CharacterImage.php
@@ -285,7 +285,7 @@ public function getDisplayTitlesAttribute() {
             $titles[] = $title->displayTitle;
         }
 
-        return implode(' ', $titles);
+        return '<div class="row">'.implode('', $titles).'</div>';
     }
 
     /**
diff --git a/app/Models/Character/CharacterImageTitle.php b/app/Models/Character/CharacterImageTitle.php
index 29bf5f4d1..d62a12ffa 100644
--- a/app/Models/Character/CharacterImageTitle.php
+++ b/app/Models/Character/CharacterImageTitle.php
@@ -66,6 +66,6 @@ public function getDisplayTitleAttribute() {
             return $this->title->displayTitle($this->data);
         }
 
-        return '<div><span class="badge ml-1" style="color: white; background-color: #ddd;">'.isset($this->data['short']) ?? $this->data['full'].'</span></div>';
+        return '<div><span class="badge ml-1" style="color: white; background-color: #ddd;">'.(isset($this->data['short']) ? $this->data['short'] : $this->data['full']).'</span></div>';
     }
 }
diff --git a/app/Models/Character/CharacterTitle.php b/app/Models/Character/CharacterTitle.php
index 5677fd126..466ea85d2 100644
--- a/app/Models/Character/CharacterTitle.php
+++ b/app/Models/Character/CharacterTitle.php
@@ -190,7 +190,7 @@ public function getAssetTypeAttribute() {
      */
     public function displayTitle($data) {
         return '<a href="'.$this->idUrl.'"><span class="badge ml-1" style="color: white; background-color: '.$this->colour.';"'.
-            ($data['full'] ? 'data-toggle="tooltip" title="'.$this->title.'">'.$data['full'] : '>'.$this->title)
+            ($data['full'] ? ' data-toggle="tooltip" title="'.$this->title.'">'.$data['full'] : '>'.$this->title)
         .'</span></a>';
     }
 }