Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Auth pull request #306

Closed
vpetersson opened this issue Sep 23, 2015 · 6 comments
Closed

Resolve Auth pull request #306

vpetersson opened this issue Sep 23, 2015 · 6 comments

Comments

@vpetersson
Copy link
Contributor

We should finalize this pull request:
#224

@vpetersson vpetersson modified the milestones: Let's give OSE some TLC, Sprint 1, Sprint 0 Sep 23, 2015
@mrneilsy
Copy link

+1. For an organisation of my size, with the potential to deploy dozens of Screenly OSEs, secure LDAP access control is a clincher. We're using the server.py auth over SSL for now. Is the LDAP ready to test? If not is it something you could give a tentative ETA for?

@vpetersson
Copy link
Contributor Author

LDAP is part of the PR, but the top priority would be to get regular auth working and part of the system.

@vpetersson
Copy link
Contributor Author

I'm torn if we should go down the route of having this natively or doing it in Nginx (see #402).

The benefit of doing it in Nginx is that it is a lot simpler (just basic auth).

The downside that it doesn't support things like LDAP.

@mrneilsy
Copy link

mrneilsy commented Dec 2, 2016

Is this still in pipeline? Basic / LDAP?

@vpetersson
Copy link
Contributor Author

@mrneilsy we're going down the route of #495 right now. it's a less complex change that wouldn't require a huge refactoring.

LDAP is a bit more complex (by the nature of the protocol).

@vpetersson
Copy link
Contributor Author

Closing this one out as this has been sorted in a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants