Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar: clearer separation between lang/theme selector and other links #381

Open
WorldLanguages opened this issue Aug 31, 2023 · 4 comments
Labels
scope: content Related to the contents of the website, excluding blog and docs scope: design Related to the web design or style type: enhancement New feature or request

Comments

@WorldLanguages
Copy link
Member

image

I think it's weird that "community" is a list of links, meanwhile the language selector is not, yet they look the same and the margin is the same as all other pairs of links.

Maybe we can add a line and some margin between "community" and the language selector. What do you think?

@WorldLanguages WorldLanguages added type: enhancement New feature or request scope: content Related to the contents of the website, excluding blog and docs scope: design Related to the web design or style labels Aug 31, 2023
@WorldLanguages
Copy link
Member Author

Note that some pages don't have a language selector. But all have a theme button.

@Hans5958
Copy link
Member

Hmm, separating it would be a good idea, but would be awkward if we add it when there is just one.

I was thinking separate in a radical way. I want to have a floating button, but again, it wouldn't look nice.

A better compromise is to put it on the footer, just like how the TypeScript Documentation (theme) and Scratch (language) does it.

@WorldLanguages
Copy link
Member Author

Actually I like these buttons at the top.
Our website is usually visited from desktop (or, more generally, wide screens) and it has no login, so we should take advantage of the space!

@Hans5958
Copy link
Member

We actually got an ideal amount of navbar links, not to crowded and not to bare, even if we remove the theme and language buttons, I think.

Also, the reason I put it to also support mobile is that to reach as many potential users, even though they would need to use their PCs to install it. Also, 8% is nice enough to reach, even if we don't prioritze it that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: content Related to the contents of the website, excluding blog and docs scope: design Related to the web design or style type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants