Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom unit creation not documented #155

Open
water-e opened this issue Feb 4, 2020 · 1 comment
Open

Custom unit creation not documented #155

water-e opened this issue Feb 4, 2020 · 1 comment

Comments

@water-e
Copy link

water-e commented Feb 4, 2020

Would it be possible to add a brief example to the Unit documentation page that describes the process of adding units or overriding conversions? We frequently work with practical salinity units and siemens for specific conductance. The former is not there (we think), the latter is. Even if psu were included, we likely would prefer our conversion because it has a tweak for low salinity in brackash agricultural waters. The Unit class itself doesn't seem to onerous to subclass. However it isn't clear exactly all the places we would need to modify in order to either add a new unit or override a conversion if it be necessary (if this is even possible). I see files like site.cfg but I don't know if it will take a second entry or whether I have to add to the xml. I also don't know how to ensure the right imports are made.

@pp-mo
Copy link
Member

pp-mo commented Sep 12, 2024

Relates to this comment
As described in my reply to that, I don't think this will fit into the current effort towards v3.3
So, I'm removing it from that board and assigning it to myself ...

@pp-mo pp-mo self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants