docs(*): update the name from anchor.fm to spotify #127
Conversation
| if (env.ANCHOR_LOGIN) { | ||
| await anchorLogin(); | ||
| if (env.SPOTIFY_LOGIN) { | ||
| await spotifyLogin(); | ||
| } else { |
There was a problem hiding this comment.
I believe there are two functions now with the same name. Could you check that this change?
There was a problem hiding this comment.
I think we won't need any if statements here since the only login type will be spotofy.
| and because pupeteer treats the page as loaded(or navigated to) | ||
| even when the form is not showed | ||
| */ | ||
| await page.waitForSelector('#email'); | ||
| await page.type('#email', env.ANCHOR_EMAIL); | ||
| await page.type('#password', env.ANCHOR_PASSWORD); | ||
| await page.type('#email', env.SPOTIFY_EMAIL); |
There was a problem hiding this comment.
We're introducing a breaking change and so we should be explicit in the doc that the latest version people need to adapt
There was a problem hiding this comment.
Where is the correct section to specify this change?
There was a problem hiding this comment.
In the readme, where we are implementing the documentation of these .env variables
|
@Wabri please update & rebase so we can publish a new release |
| ANCHOR_LOGIN: true, | ||
| ANCHOR_EMAIL: '', | ||
| ANCHOR_PASSWORD: '', | ||
| SPOTIFY_LOGIN: true, |
There was a problem hiding this comment.
I think that you don't need to add any other environment variables. You can just delete the ANCHOR_ env variables.
|
Please rename folder |
Closes #126