Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The whole app is mem-leaking (kind of) #22

Open
yedpodtrzitko opened this issue Dec 5, 2012 · 2 comments
Open

The whole app is mem-leaking (kind of) #22

yedpodtrzitko opened this issue Dec 5, 2012 · 2 comments
Labels
bug

Comments

@yedpodtrzitko
Copy link
Contributor

<body> content is chained to existing one and the whole app gets slower and slower.

steps to reproduce (+example):

  • click any links

random clicking result (mostly articles/new article/photos/new photo):

>>> $("body")[0].innerHTML.length

3608

>>> $("body")[0].innerHTML.length

21755

>>> $("body")[0].innerHTML.length

68126

steal.js INFO:

Model.js - Model created
dev.js (line 85)

>>> $("body")[0].innerHTML.length

41909

>>> $("body")[0].innerHTML.length

32243

>>> $("body")[0].innerHTML.length

49607

>>> $("body")[0].innerHTML.length

54365

>>> $("body")[0].innerHTML.length

55835

>>> $("body")[0].innerHTML.length

60593

>>> $("body")[0].innerHTML.length

62063

>>> $("body")[0].innerHTML.length

66821

>>> $("body")[0].innerHTML.length

68291

>>> $("body")[0].innerHTML.length

73049

>>> $("body")[0].innerHTML.length

74519

>>> $("body")[0].innerHTML.length

79277

>>> $("body")[0].innerHTML.length

69611

>>> $("body")[0].innerHTML.length

86975

>>> $("body")[0].innerHTML.length

133346
@yedpodtrzitko
Copy link
Contributor Author

I think problem is in datepicker plugin. Also I think it should be encapsulated via can.control.plugin (see http://canjs.us/#plugins-can_control_plugin ).

@mrpohoda
Copy link
Contributor

When this pull request will be accepted, we set the parent element inside control's scope. Then datepicker will be removed automatically when control is destroyed.

closeio/bootstrap-datepicker@5b6d938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yedpodtrzitko @mrpohoda