Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open WebSocketEventStream #276

Open
asxtray opened this issue Jun 24, 2019 · 1 comment
Open

Can't open WebSocketEventStream #276

asxtray opened this issue Jun 24, 2019 · 1 comment

Comments

@asxtray
Copy link

asxtray commented Jun 24, 2019

it seems that WebSocketEventStream can only work with insecure http sockets. Please have a look at line 46:
URI adjustedURI = (new URI(uri.getScheme() == "https" ? "wss" : "ws", uri.getSchemeSpecificPart(), uri.getFragment())).resolve("ws/" + token.getToken());
Despite the provided uri schema is HTTPS it fails direct comparison as it's String object reference

@NemanyaM
Copy link

@asxtray Actually, seems that there is no HTTPS implementation at all, as I could see, in this part of a project, if I am right by any chance, the ternary condition could be removed. Also, maybe constants could be introduced for better readability and as a good practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants