-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module name information to Call classes. #149
Comments
I would appreciate if you can provide a bit more information regarding this requirement. |
The general idea of this was to have the |
Ok back to the original issue. Two scenarios. 2nd, add another constructor which accepts module name as a separate parameter to function. Furthermore, function parameter can also be changed to an array of strings or varargs like {high, low} if want to pass more than one function. Also, instead of functions as Strings we can introduce Enums with all the functions of a module. Pleas bear with me if am writing some not so intelligent stuff, i haven't get much chance to contribute in community before so ignore it if anything is rude or so. It's going to be my 1st PR in community project so i am way more conscious in my approach. |
@admd if there is common code that can be put in a super class that would be very welcome. 👍 |
After the merge of #197 this issue is partly fixed: we now have the module information available, but we still would want to have a getter for only the function name. Note that the current |
I will take care of this on weekend . |
This will allow us to use the call objects to generate input for functions like
state.high
andstate.low
.The text was updated successfully, but these errors were encountered: