Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda-forge package #79

Open
jan-janssen opened this issue Apr 29, 2019 · 8 comments
Open

conda-forge package #79

jan-janssen opened this issue Apr 29, 2019 · 8 comments
Labels
help wanted Extra attention is needed

Comments

@jan-janssen
Copy link

jan-janssen commented Apr 29, 2019

I started building a conda-forge package:
https://github.com/conda-forge/catlearn-feedstock

And I was wondering if catlearn/api/magpie can be compiled from code as well, or maybe distributed as a separate package.

@mhangaard
Copy link
Collaborator

mhangaard commented Apr 29, 2019

Hi Jan, thank you for taking care of the package in conda-forge.
I agree, this is an issue that must be fixed. magpie should be treated properly as an external dependency.
This is where it is imported: https://github.com/SUNCAT-Center/CatLearn/blob/master/catlearn/fingerprint/voro.py

@mhangaard mhangaard added the help wanted Extra attention is needed label Apr 29, 2019
@mhangaard
Copy link
Collaborator

This is the original source of Magpie: https://bitbucket.org/wolverton/magpie

@jan-janssen
Copy link
Author

@WardLT Can you help us? Are there any plans to add magpie to anaconda? Or is it more reasonable to extract the voronoi fingerprint and implement it directly in Python using voro++ bindings?

@WardLT
Copy link

WardLT commented Apr 29, 2019

I do not currently have plans to put Magpie on conda. However, I have re-implemented the Voronoi fingerprints and most other descriptors in matminer. There is an example for the Voronoi specifically: notebook

Will that work?

@mhangaard
Copy link
Collaborator

There is even a Python wrapper for magpie by Wolverton group: https://bitbucket.org/wolverton/magpie-python

@WardLT
Copy link

WardLT commented Apr 29, 2019

How does catlearn's Magpie interaction work? Does it use the REST API for Magpie or the text interface?

@jan-janssen
Copy link
Author

@WardLT
Copy link

WardLT commented Apr 29, 2019

Maybe a good short-term fix would be to download the Magpie JAR file on demand. I have put it up on Bitbucket: https://bitbucket.org/wolverton/magpie/downloads/Magpie.jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants