Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect (col, row) returned for asteroid 4077 in sector 2 #4

Open
barentsen opened this issue Feb 26, 2021 · 5 comments
Open

Incorrect (col, row) returned for asteroid 4077 in sector 2 #4

barentsen opened this issue Feb 26, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@barentsen
Copy link
Contributor

Asteroid 4077 in sector 2 was reported by @christinahedges to display a strange kink in its (col, row) trajectory, which is almost certainly incorrect because its (ra, dec) trajectory on the sky is a straight line. It looks like the WCS transform can yield incorrect (col, row) values after an object has moved off the ccd.

I'm in the process of debugging this and adding a unit test.

Example bug:

Screen Shot 2021-02-26 at 10 37 25 AM

@barentsen barentsen added the bug Something isn't working label Feb 26, 2021
@barentsen barentsen self-assigned this Feb 26, 2021
@barentsen
Copy link
Contributor Author

I'm somewhat stuck with this issue because it looks like the FFI WCS truly thinks the straight (ra, dec) trajectory of the asteroids translates into a weird curved path in (col, row) pixel coordinate space.

Example:

Screen Shot 2021-03-03 at 10 13 45 AM

@christinahedges
Copy link

Yikes, this seems interesting!
What happens if you plot an image of the X, Y to RA, Dec, conversion something like:

Y, X = np.mgrid[:2048,:2048]
ra, dec = wcs.all_pix2world(np.vstack([X.ravel(), Y.ravel()]).T, 0)

plt.imshow(ra)
plt.imshow(dec)

Can you see that it looks funky in the corners?

@barentsen
Copy link
Contributor Author

Thanks, that's a good idea!!

It looks like the RA=0 meridian runs through the image. This may be a clue...

Screen Shot 2021-03-03 at 10 42 54 AM

@barentsen
Copy link
Contributor Author

Update: tess-point agrees with the weird curve in the trajectory, so I'm really confused now...

Screen Shot 2021-03-15 at 6 28 30 PM

@barentsen
Copy link
Contributor Author

I am starting to think that there is no bug in tess-locator, because I am able to reproduce the funny kink in the trajectory using tess-point. My leading suspicion is that the stretch on the Y limit in the screenshot posted at the top of this issue made led me astray into thinking there is an obvious error in the WCS transform, but in reality, the kink is very subtle and visible in both (ra, dec) and (col, row) space.

Example:

Screen Shot 2021-03-16 at 9 23 16 AM

Screen Shot 2021-03-16 at 9 24 12 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants