Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Metadynamics compatible with restart API #268

Open
yzjin opened this issue Jun 11, 2023 · 1 comment
Open

Making Metadynamics compatible with restart API #268

yzjin opened this issue Jun 11, 2023 · 1 comment

Comments

@yzjin
Copy link
Collaborator

yzjin commented Jun 11, 2023

Currently the Metadynamics method only supports static number of gaussians (code) as the length of the states are determined at the initialization. In cases where a metadynamics simulation has been restarted, no new gaussians will be recorded. Furthermore, such error will fail silently. Given that creating arrays with variable length is hard in Jax, I think there can be several ways to make it compatible:

  • Asks user to give a larger ngaussians when initializing the Metadynamics object. No more code is required in such cases, but the docstring needs to be edited to make it compatible to current design.
  • When reloading the state from a previous result during the restart, add an additional function that edits the result. For the metadynamic case, this function should enlarge the size of the array by the number of ngaussians that is provided by the user, and return it as the new state.
@pabloferz
Copy link
Member

Thanks @yzjin! We could handle this as a documentation issue for the time being, so let's try to get a fix for the first option. But, I do agree that it would be nice to handle the second case as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants