Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytical intent generalization from controls. #218

Open
jakebeal opened this issue Jul 27, 2020 · 6 comments
Open

Analytical intent generalization from controls. #218

jakebeal opened this issue Jul 27, 2020 · 6 comments
Assignees
Labels
new feature New feature
Milestone

Comments

@jakebeal
Copy link
Contributor

Analytical intent should be able to be generalized fairly simply by building off of #93.

@mwes please provide a specification to be targeted, and then reassign to @tramyn for implementation.

@jakebeal jakebeal added this to the 2.8 milestone Jul 27, 2020
@mwes
Copy link
Contributor

mwes commented Jul 30, 2020

My suggested path forward:

  1. @mwes extend schema to support specification of schema-controlled sample tags based on the existing control definition structures

2a. @mwes update all existing SRs, run tag annotation for all experiments

2b. (in parallel) @tramyn targets specification defined in 1 through IP interface; we use this for all new ERs going forward

@tramyn
Copy link
Collaborator

tramyn commented Aug 18, 2020

@mwes is your schema extended for me to get started on this issue?

@mwes
Copy link
Contributor

mwes commented Aug 18, 2020

@tramyn not yet, I'll get to this this week; I am working on resolving several metadata issues for newly uploaded experiments.

@tramyn tramyn modified the milestones: 2.8, 2.9 Aug 18, 2020
@tramyn tramyn added the new feature New feature label Aug 21, 2020
@mwes
Copy link
Contributor

mwes commented Aug 28, 2020

Other issues have normalized - I'll plan to return to this when I return from leave on Monday, August 31

@tramyn
Copy link
Collaborator

tramyn commented Sep 2, 2020

@mwes Could you provide me updates on this issue? What is its current state?

@mwes
Copy link
Contributor

mwes commented Sep 2, 2020

@tramyn thanks for following up. I've proposed a schema extension here: https://gitlab.sd2e.org/sd2program/cp-request/merge_requests/516 that follows the existing control structure, but relaxes the need to have a constrained "type".

We'll be able to see from ER usage what label values are used, which we can then constrain with a targeted enumeration to guide population. The JSON target is almost identical to the current "controls" object, but I am storing this under an independent "labels" section that we can manage separately if we find it needs changes or extensions. The only functional difference between this and how we currently define controls is a relaxation the "type" value - any string.

Example:

"labels": [{
    "contents": [{
        "name": {
            "label": "SC Media",
            "sbh_uri": "https://hub.sd2e.org/user/sd2e/design/culture_media_1/1"
        }
    }],
    "strains": [
        "https://hub.sd2e.org/user/sd2e/design/W303/1"
    ],
    "timepoints": [{
        "unit": "hour",
        "value": 0.0
    }],
    "type": "SOME_USER_LABEL"
}]

@tramyn tramyn modified the milestones: 2.9, 2.10 Sep 14, 2020
@tramyn tramyn modified the milestones: 2.11, 2.12, 2.13 Oct 27, 2020
@tramyn tramyn modified the milestones: 3.2, 3.3 Jan 29, 2021
@jakebeal jakebeal modified the milestones: 3.4, 4.0 Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants