Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in helm chart + add support for pod affinity #459

Closed
yyardeng opened this issue Aug 18, 2024 · 3 comments
Closed

bug in helm chart + add support for pod affinity #459

yyardeng opened this issue Aug 18, 2024 · 3 comments

Comments

@yyardeng
Copy link

yyardeng commented Aug 18, 2024

version 0.6.5 of the operator helm chart has a bug in the deployment template where the variable checked in the if condition for the node selector and tolerations is not the value that is used in the template:

      {{- if .Values.manager.nodeSelector }}
      nodeSelector: {{ toYaml .Values.deployment.nodeSelector | nindent 8 }}
      {{- end }}
      {{- if .Values.manager.tolerations }}
      tolerations: {{ toYaml .Values.deployment.tolerations | nindent 8 }}
      {{- end }}

which means the values have to be set twice in the values file for the configuration to take effect.

in addition, it would be great if support for configuring affinity in the deployment could be added.
perhaps something like:

      {{- with .Values.manager.affinity }}
      affinity:
        {{- toYaml . | nindent 8 }}
      {{- end }}

adding support for topologySpreadConstraints instead or in addition to affinity would be helpful as well.

@I065450
Copy link
Collaborator

I065450 commented Aug 19, 2024

Hi @yyardeng

Please review PR: #460 if it meets your request.

Regards,
Naama

@yyardeng
Copy link
Author

yyardeng commented Aug 19, 2024

@I065450 yes, thank you - it would be great to get support for topology spread constraints as well since that feature is better for high availability purposes (GA since 1.19, in case this is relevant). it would be something like:

      {{- with .Values.manager.topologySpreadConstraints }}
      topologySpreadConstraints:
        {{- toYaml . | nindent 8 }}
      {{- end }}

@I065450
Copy link
Collaborator

I065450 commented Aug 26, 2024

fixed in PR: #460

@I065450 I065450 closed this as completed Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants