Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier in svelte files #4000

Open
walmazacn opened this issue Oct 23, 2024 · 1 comment · May be fixed by #4002
Open

Run prettier in svelte files #4000

walmazacn opened this issue Oct 23, 2024 · 1 comment · May be fixed by #4002
Assignees
Labels
follow up Follow up tasks

Comments

@walmazacn
Copy link
Contributor

Run prettier in svelte files when the following issue is merged:
#3998

@walmazacn walmazacn added the follow up Follow up tasks label Oct 23, 2024
@walmazacn walmazacn self-assigned this Oct 23, 2024
@ndricimrr
Copy link
Contributor

Randomly caught on this... I remember we had some "issues" on Adds prettier commit hook for svelte files specifically regarding prettier and plugin migration from 1 - 3 so we decided to skip and keep v1 because of some new syntax introduced.

I think the Bump svelte and prettier-plugin-svelte is valid concern from dependabot, but might need to be careful and investigate before getting this PR (#3999) merged and what 'damage' does it cause to Svelte files if any.

If there's no issue with the resulting Svelte prettier changes after all (bundles OK and syntax looks good), then instead of just applying Prettier in Svelte Files, maybe it would be best to apply it to the whole repo with npm run full-code-quality-prettier at once to avoid future merge conflicts. Tried that on this branch (3998-bump-prettier-and-prettier-plugin-svelte) and it outputted 170+ File changes (.HTML, .js, .ts, .svelte, ).

@walmazacn walmazacn linked a pull request Oct 24, 2024 that will close this issue
@walmazacn walmazacn linked a pull request Oct 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow up Follow up tasks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants