From 1d5368145283d90be315d5393b3d00cf407bbaf4 Mon Sep 17 00:00:00 2001 From: "mikerodonnell89@gmail.com" Date: Tue, 8 Oct 2024 14:50:13 -0400 Subject: [PATCH 1/2] fix(core): input group should not fall back to glyph for button title --- libs/core/src/lib/input-group/input-group.component.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libs/core/src/lib/input-group/input-group.component.html b/libs/core/src/lib/input-group/input-group.component.html index af87098cc2b..67202e3138b 100644 --- a/libs/core/src/lib/input-group/input-group.component.html +++ b/libs/core/src/lib/input-group/input-group.component.html @@ -30,7 +30,7 @@ [fdType]="inShellbar ? 'standard' : 'transparent'" [id]="_addOnButtonId" [attr.tabindex]="buttonFocusable ? 0 : -1" - [attr.title]="iconTitle || glyphAriaLabel || glyph" + [attr.title]="iconTitle || glyphAriaLabel" [glyph]="glyph" [class.fd-shellbar__button]="inShellbar" [class.is-expanded]="isExpanded" @@ -54,7 +54,7 @@ [id]="_addOnNonButtonId" [placement]="placement" [attr.aria-label]="glyphAriaLabel || glyph || addOnText" - [attr.title]="iconTitle || glyph || addOnText" + [attr.title]="iconTitle || addOnText" > {{ addOnText }} From cb8a4cce959e489bc68fe5951ceac6aeef212ceb Mon Sep 17 00:00:00 2001 From: "mikerodonnell89@gmail.com" Date: Thu, 10 Oct 2024 13:43:50 -0400 Subject: [PATCH 2/2] fix(core): fix e2e test --- libs/docs/core/multi-input/e2e/multi-input.po.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/docs/core/multi-input/e2e/multi-input.po.ts b/libs/docs/core/multi-input/e2e/multi-input.po.ts index 547f34052f1..4f871dcca41 100644 --- a/libs/docs/core/multi-input/e2e/multi-input.po.ts +++ b/libs/docs/core/multi-input/e2e/multi-input.po.ts @@ -3,7 +3,7 @@ import { CoreBaseComponentPo, waitForElDisplayed, waitForPresent } from '../../. export class MultiInputPo extends CoreBaseComponentPo { private url = '/multi-input'; - activeDropdownButtons = 'button[title="value-help"]:not(:disabled)'; + activeDropdownButtons = 'button:not(:disabled) .sap-icon--value-help'; activeInputs = '.fd-multi-input-field input:not(:disabled)'; disableInputs = 'div.is-disabled'; simpleMultiInputOptions = '.fd-popover-custom-list [fd-list-item] fd-checkbox';