-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
srp: why M1 is not calculated according to the spec? #152
Comments
tarcieri
changed the title
Why M1 is not calculated according to the spec?
srp: why M1 is not calculated according to the spec?
Sep 14, 2023
For context this is regarding the changes in #79. A PR sounds good. I think there will be some bikeshedding about naming, but otherwise we can hash out the details there. |
It's up. Please let me know if you like this implementation or I need to try another approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello.
I was using your library in my code for a couple of years. I just updated it, and saw that
M1
calculation has changed.I see this comment where it is calculated:
It makes sense that you decided to go with what most of the users prefer, but it is breaking functionality of my code.
I'm suggesting to add those back beside current ones, so there will be a
proof()
function and maybe aproof_std()
that uses standard implementation ofM1
calculation, and also there will be averify_server_std()
besideverify_server()
that calculatesM2
using this newM1
.Or just add a
process_reply_std()
that returns aSrpClientVerifier
with the otherM1
andM2
.I can also send a PR if you need me to.
Thanks in advance
The text was updated successfully, but these errors were encountered: