-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Codspeed for testing #24
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Codspeed is a performance testing tool designed to produce highly consistent performance measurements. It also integrates very cleanly with
criterion.rs
.I prototyped this out in bifurcation#1. (Unfortunately, that also includes a bunch of noise due to main branch divergence. The main commit is bifurcation@30a1c59.) In addition to those code changes, an admin for the
RustCrypto
org would have to enable Codspeed for the repo and provision the required secret.I'm having a little trouble having confidence in the measurements, though. Looking at bifurcation#3 and its Codspeed report, it is measurably slower on my local machine, but Codspeed reports marginal performance improvements. The execution times are also off by about an order of magnitude.
The version in that prototype is pretty slow, because it builds everything afresh, as @newpavlov noted in the accidental PR #20. If we're going to do this, we should do something like @newpavlov suggests to make it faster.
The text was updated successfully, but these errors were encountered: