Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line numbers to output #1

Open
asgrim opened this issue Jul 15, 2019 · 0 comments
Open

Add line numbers to output #1

asgrim opened this issue Jul 15, 2019 · 0 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@asgrim
Copy link
Member

asgrim commented Jul 15, 2019

I'd previously added line numbers to be displayed based on the line_from value. However, this is actually the line that the problem started on, rather than the line that the snippet started on. From my work so far, snippet_from is the only guidance to know what line we start on: however, the snippet_from is the character the snippet starts on, rather than the line. AFAIK the only way to figure out what line the snippet starts on would be to count \r or \n or \r\n between characters 0 and <snippet_from> ... :/ so not sure where to go here.

@asgrim asgrim added bug Something isn't working help wanted Extra attention is needed labels Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant