Never end #22
Labels
Comments
|
I have tested with roave/no-leaks 1.1.1, roave/no-leaks 1.1.0, roave/no-leaks 1.0.0. The version 1.0.0 does not have this bug |
|
Do you by chance have other plugins installed? |
|
No plugins for phpunit, here is my phpunit.xml <phpunit
bootstrap="./tests/bootstrap.php"
colors="true"
backupGlobals="false"
convertNoticesToExceptions="false"
convertWarningsToExceptions="false"
>
<testsuites>
<testsuite name="....">
<directory>....</directory>
</testsuite>
.... and many others
</testsuites>
<filter>
<whitelist addUncoveredFilesFromWhitelist="true">
<directory suffix=".php">./src/</directory>
<exclude>
<directory suffix=".php">.....</directory>
</exclude>
</whitelist>
</filter>
</phpunit>And when its working i dont have any output, i make another issue |
|
What happens if you drop the no-leaks/bin/roave-no-leaks.php Line 46 in ec6aa10 |
|
same PHPUnit 8.3.5 by Sebastian Bergmann and contributors.
Runtime: PHP 7.3.4
Configuration: /var/www/phpunit.xml
............................................................... 63 / 751 ( 8%)
...................................................SS.......... 126 / 751 ( 16%)
............................................................... 189 / 751 ( 25%)
............................................................... 252 / 751 ( 33%)
............................................................... 315 / 751 ( 41%)
............................................................... 378 / 751 ( 50%)
............................................................... 441 / 751 ( 58%)
.......................I.I..................................... 504 / 751 ( 67%)
............................................................... 567 / 751 ( 75%)
................................................III.I.......... 630 / 751 ( 83%)
............................................................... 693 / 751 ( 92%)
.......................................................... 751 / 751 (100%)..... 756 / 751 (100%)
............................................................... 819 / 751 (109%)
............................................................... 882 / 751 (117%)
...........................................^ |
|
What about ? Maybe we have to check if that test is already registered? |
|
when i add on |
|
with this patch /** @var array<string> */
private static $addSuited = [];
public function startTestSuite(TestSuite $suite) : void
{
if (array_key_exists($suite->getName(), self::$addSuited)) {
var_dump('ignore add');
return;
}
self::$addSuited[$suite->getName()] = true;
$suite->addTest(new EmptyBaselineMemoryUsageTest(EmptyBaselineMemoryUsageTest::TEST_METHOD));
}i've got this strange output Its like after some time, phpunit considers randomly unit test has a testSuite |
|
Hmm, tricky. Do you by chance have any |
|
i have no special annotation for phpunit. |
|
Maybe dump more information in the |
|
I've made a test with Roave/no-leaks. i have added var_dump(__METHOD__.' '.$suite->getName()); on and var_dump(__METHOD__.' '. $result->count());on result : I think startTestSuite shouldn't be called on every test, is it me or i don't understand ? |
|
Yeah, I think so too - probably a bug in upstream then? |
|
Ok, so i open an issue in phpunit |
|
thanks for the support 👍 |
|
Let's leave this open until it's clear where the bug lies, heh... |
|
@Ocramius : reported on sebastianbergmann/phpunit#3877 |
|
i certainly found the real problem here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
The tests suite never end with
./vendor/bin/roave-no-leaks, I have to stop it by hand, so I don't have any results.Tested with phpunit 8.0., phpunit 8.1. phpunit 8.2., phpunit 8.3.
Tested with php version
and
roave/no-leaks version 1.1.1
Do you have an idea how to debug this ?
Thanks in advance !
The text was updated successfully, but these errors were encountered: