Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to get property 'order' of non-object #69

Open
yabushraber opened this issue Jun 4, 2020 · 1 comment
Open

Trying to get property 'order' of non-object #69

yabushraber opened this issue Jun 4, 2020 · 1 comment

Comments

@yabushraber
Copy link

file Riskified/DecisionNotification/Model/Notification.php line (97)
$order = $body->{'order'};
Trying to get property 'order' of non-object:

Setting true as second parameter causes a problem in PHP 7.4, since it returns associative array(not object):
$body->{'order'} reading object
$body["order"] reading array

can you please use array or object syntax, but not both
thank you

@jtraviscc
Copy link

The tag 1.9.0 is between the commit above and the fix. Please tag after the commit as 1.9.1 so it can actually be stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants