Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method all_released_ids_for doesn't return a released_to_all response #47

Open
GLOFonseca opened this issue Apr 3, 2019 · 1 comment
Labels

Comments

@GLOFonseca
Copy link
Contributor

Problem

When one checks all_released_ids_for a feature that was release_to_all, FeatureFlagger returns the ids from the accounts with the rollout before the release_to_all method. So we need a response informing that feature was released to all.

Example

account.release(:foo, :bar)
=>  true
Account.release_to_all(:foo, :bar)
=> true
Account.all_released_ids_for(:foo, :bar)
=> "1"
@GLOFonseca GLOFonseca added the bug label Apr 3, 2019
@matheuslc
Copy link

@GLOFonseca questions

  • It's important to know what the ids previously released before the release to all?

  • What's would be the best response in this scenario? I do not want to return a different response type for this method, like "released_to_all". I think that would be better to use the already implemented method called released_to_all? for this purpose. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants