Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rake to generate YAML file #20

Open
lcezermf opened this issue Sep 20, 2016 · 3 comments
Open

Rake to generate YAML file #20

lcezermf opened this issue Sep 20, 2016 · 3 comments

Comments

@lcezermf
Copy link
Contributor

lcezermf commented Sep 20, 2016

Provide a rake to generate initial YAML file for the projects.

This issue was extracted from a comment on code.

@geisonbiazus @nandosousafr for this issue, it's better to use:

  • Simple rake task that creates the rollout.yml inside RAILS_APP/config path.
  • Something like a Rails Generator

💡 💭

@geisonbiazus
Copy link
Contributor

Nice @lccezinha, it would be great!

But we have to take care. Rails mustn't become a dependency of the project. If we want to use feature_flagger in a non rails app, it should be no problem. But the gem still can verify for rails existence and have a generator.

Something like:

rails generate feature_flagger:setup

@lcezermf
Copy link
Contributor Author

Another option that I found, that does not depend on Rails Generators, is using Thor - (Rails Generators use Thor in a low-level).

What do you guys thing about it ?

@geisonbiazus
Copy link
Contributor

geisonbiazus commented Sep 27, 2016

Nice @lccezinha but I don't think it's worth it since it will only generate an empty rollout.yml file for now and it will also add a new depency that we actually don't need. I'd go for rails generator checking if Rails is defined (we don't add rails as a dependency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants