Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array type doesn't find json $ref pointers #12

Open
craigmulligan opened this issue Aug 7, 2019 · 0 comments
Open

Array type doesn't find json $ref pointers #12

craigmulligan opened this issue Aug 7, 2019 · 0 comments

Comments

@craigmulligan
Copy link
Contributor

craigmulligan commented Aug 7, 2019

Currently, when we encounter an array type and when trying to access the subtype by doing items.get('type') it throws as the postgres-tapoutputs theitemswith a json $ref pointer which can be found in the catalogues definitions. eg we expectitems[{ type: 'string' }]but actually receiveitems[{ $ref: }]`

I'd expect that singer's message parsing function would use jsonref or a similar to load the references for the target. Unless you can think of a reason not to do that I'll open an issue on the core singer lib and link back to this.

In the meantime, we could look for a $ref and resolve it our selves. Although this approach is probably error-prone.

@craigmulligan craigmulligan changed the title Array type doesn't follow find json $ref type Array type doesn't find json $ref type Aug 7, 2019
@craigmulligan craigmulligan changed the title Array type doesn't find json $ref type Array type doesn't find json $ref pointers Aug 7, 2019
herregroen pushed a commit to Yoast/target-bigquery that referenced this issue Feb 17, 2021
…hema_keys

Transform invalid schema keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant