Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Rack metadata middleware from RailsEventStore gem #641

Open
mostlyobvious opened this issue Jul 1, 2019 · 3 comments
Open

Extract Rack metadata middleware from RailsEventStore gem #641

mostlyobvious opened this issue Jul 1, 2019 · 3 comments

Comments

@mostlyobvious
Copy link
Member

It is possible to use Rack middleware that enhances recorded events metadata outside of Rails. Yet we ship it in the Rails version of the gem (rails_event_store): https://github.com/RailsEventStore/rails_event_store/blob/409339adbe094dabd439e15e46daaf145be7f647/rails_event_store/lib/rails_event_store/middleware.rb

A wider audience could benefit from it if that was present in ruby_event_store. Still, rails_event_store may continue enabling it by default:
https://github.com/RailsEventStore/rails_event_store/blob/409339adbe094dabd439e15e46daaf145be7f647/rails_event_store/lib/rails_event_store/middleware.rb

@joelvh
Copy link
Contributor

joelvh commented Jul 1, 2019

What are your thoughts about putting much more into “contrib”? Things like Rack and workers and other plumbing to integrate in many ways? All the modular “plugins”, essentially. I saw your other ticket about documenting how to use RES with Hanami and Sidekiq, and also to separate AR from Rails — put all the pieces in contrib and then have a place that helps pull the pieces together for different integrations, etc.

@mostlyobvious
Copy link
Member Author

@joelvh Feel free to put more intro contrib/. So far the common thing about it is that code there does not get released along "official" RES gems and does not necessarily has to follow 100% mutation coverage nor versioning rules.

I'd be glad to see there more stuff ✨

@mostlyobvious
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants