Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display SSH connection errors #90

Open
Rahix opened this issue Apr 12, 2023 · 0 comments
Open

Display SSH connection errors #90

Rahix opened this issue Apr 12, 2023 · 0 comments
Labels
feature Enhancement/New feature has-workaround This issue can temporarily be fixed by a hack/workaround visuals Related to the user-facing output of tbot

Comments

@Rahix
Copy link
Owner

Rahix commented Apr 12, 2023

Right now, when an SSH connection fails, no useful error message is shown. If a user wants to find out why the connection failed, they have to retry in channel-debug mode (newbot -v) to see the error printed by the ssh command.

Ideally, tbot should detect the connection failure and log the error message before raising an exception. This is a bit tricky because the error shows up right in a spot where we also expect data that we don't want to log to console (shell initialization).

A possible solution may be to detect a closed channel during ssh initialization and only log output then. This may have timing problems, though.

@Rahix Rahix added has-workaround This issue can temporarily be fixed by a hack/workaround feature Enhancement/New feature visuals Related to the user-facing output of tbot labels Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancement/New feature has-workaround This issue can temporarily be fixed by a hack/workaround visuals Related to the user-facing output of tbot
Projects
None yet
Development

No branches or pull requests

1 participant