Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new HP models #84

Merged
merged 37 commits into from
Sep 30, 2024
Merged

Adapt to new HP models #84

merged 37 commits into from
Sep 30, 2024

Conversation

FWuellhorst
Copy link
Contributor

Closes #83

@ebc-aixlib-bot
Copy link

Thank you for making a Pull Request to BESMod!

Our CI pipeline will help you finalize your contribution.
Here's what is typically checked:

  • HTML syntax of your models, primarily in your documentation.
  • Adherence to the naming convention in all changed files.
  • Ability to check all models.
  • Ability to simulate all models, if they are examples.
  • If your contribution changes existing reference results.

If HTML errors occur, I will fix the issues using a separate pull request.
For the other checks, I will post the results here: https://rwth-ebc.github.io/BESMod/83_newHPmodels/index.html

Tips to fix possible naming violations:

  • Stick to the naming guidelines, e.g. Namespace Requirements
  • Do all paramaters, variables, models, etc. have a description?
  • Use absolute paths to classes! -> BESMod.Fluid.HeatExchangers.Radiator - Avoid: HeatExchangers.Radiator

If all CI stages pass and you have addressed possible naming violations, please consider the following:

  • Use "group" and "tab" annotations to achieve a good visualization window.
  • Use units consistently.
  • Instantiate the replaceable medium package as:
    replaceable package Medium = Modelica.Media.Interfaces.PartialMedium "Medium model";
    instead of using a full media model like BESMod.Media.Water directly.
  • Never using absolute paths to files (e.g., C: or D:). Replace them with modelica://BESMod/....
  • Ensure your documentation is helpful and concise.
  • Make sure icons are clear. Please avoid using images!
  • Stick to 80 characters per line, as long as it makes sense.
  • Add or modify examples for new or revised models.
  • Include a simulate-and-plot script as a regression test for new models.
    How? Follow the documentation here: https://github.com/ibpsa/modelica-ibpsa/wiki/Unit-Tests#how-to-include-models-as-part-of-the-unit-tests
    Tip: To create the initial script, you can use Dymolas script generator, explained here: https://www.claytex.com/tech-blog/how-to-use-a-plot-script/)

Once you have addressed these points, you can assign a reviewer.
Although this process may seem tedious, ensuring CI passes allows the reviewer to focus
their time on the actual modeling rather than syntax and unintended breakages caused by your changes.

If you have any questions or issues, please tag a library developer.
Once again, thank you for your valuable contribution!

@ebc-aixlib-bot
Copy link

Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

@ebc-aixlib-bot
Copy link

Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

1 similar comment
@ebc-aixlib-bot
Copy link

Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

@ebc-aixlib-bot
Copy link

Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

@ebc-aixlib-bot
Copy link

Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
@ebc-aixlib-bot
Copy link

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
@ebc-aixlib-bot
Copy link

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
@ebc-aixlib-bot
Copy link

Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

@ebc-aixlib-bot
Copy link

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
@ebc-aixlib-bot
Copy link

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
@Mov0
Copy link

Mov0 commented Sep 5, 2024

When using this branch the HP only starts below the bivalent point. When using BESMod.Systems.Hydraulical.Control.MonoenergeticHeatPumpSystem as control and BESMod.Systems.Hydraulical.Generation.HeatPumpAndElectricHeater as generation the safety control of the heat pump prevents it from starting up if there is not a minimum flow through the condenser. However the condenser side pump only spins up if at least one heat generation device (hp/electric) is running. Essentially safety control and the control for the pump lock itself until the outdoor temperature falls below the bivalent point and the electric heater starts up, allowing the pump to spin.

@ebc-aixlib-bot
Copy link

Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

@ebc-aixlib-bot
Copy link

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

@ebc-aixlib-bot
Copy link

Errors in regression test. Compare the results on the following page\n https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

@ebc-aixlib-bot
Copy link

Reference results have been displayed graphically and are created under the following page https://rwth-ebc.github.io/BESMod/83_newHPmodels/charts

…ion reference files. Please pull the new files before push again. Plottet Results /83_newHPmodels/charts/
Copy link
Contributor Author

@FWuellhorst FWuellhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes, the changes work for myself and @Mov0. Going to merge now.

@FWuellhorst FWuellhorst merged commit a00aef3 into main Sep 30, 2024
1 check passed
@FWuellhorst FWuellhorst deleted the 83_newHPmodels branch September 30, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to IBPSA HP models
3 participants