Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a database instead of json #19

Open
NicEastvillage opened this issue Oct 22, 2020 · 5 comments
Open

Consider a database instead of json #19

NicEastvillage opened this issue Oct 22, 2020 · 5 comments

Comments

@NicEastvillage
Copy link
Contributor

The json file is growing quickly, but json is not a great long term. We should consider moving to a proper database at some point. This ofc comes with multiple complications - like where should it be hosted. For now I am just opening this issue for potential discussion.

@VirxEC
Copy link
Contributor

VirxEC commented Oct 22, 2020

Use postgresql & host it on Heroku - that should be just fine

@oxrock
Copy link

oxrock commented Oct 22, 2020

I get the impression that it would take a long time for it to grow to the point of being unwieldy. But future proofing is generally a good idea. Might be a nice easy project to tackle for a fledgling developer.

@kipje13
Copy link

kipje13 commented Oct 22, 2020

While I agree that a relational database would be better suited for this data, a relational database can significantly improve the consistancy of the data. However, I am not sure if it would be worth the effort because it does make the entire setup much more complicated.

If anything we could write some automated tests to quickly validate the json when reviewing PRs.

@tarehart
Copy link
Contributor

Yeah, and the current setup has some great properties:

  • Free
  • Review / approval workflow
  • Loads instantly
  • Fewer moving parts to break
  • Easy to change data format
    • Don't need to alter an add / edit form
    • Don't need to write and test a SQL update script
  • Don't need to manage / share database passwords
  • Simple enough for anyone to take over / contribute to
  • Changes fully auditable and synced with the UI code

@NicEastvillage
Copy link
Contributor Author

Definitely. Those properties should not be taken for granted. It's not like I think we need to switch any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants