Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Individual Equity Option Contracts Requesting Data Examples #1883

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add Individual Equity Option Contracts Requesting Data Examples #1883

wants to merge 7 commits into from

Conversation

LouisSzeto
Copy link
Collaborator

Description

Add Individual Equity Option Contracts Requesting Data Examples

Related Issue

closes #1876

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • New feature (non-breaking change which adds functionality)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

AlexCatarino
AlexCatarino requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@AlexCatarino AlexCatarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first two example are incorrect, since they use the AddOption method. On this page, Individual Contracts, we use OptionChainProvider+AddOptionContract.

@AlexCatarino
Copy link
Member

For example 3, please check out this example: 11df87. where I use indicator history. It's simpler than using a history request, although you might be making a QuoteBar history for some reason.

@LouisSzeto LouisSzeto force-pushed the refactor-equity-options-request-individual-contract-examples branch from ebdf682 to 0a721cc Compare November 6, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexCatarino AlexCatarino AlexCatarino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examples Issue: Securities / Equity Options / Requesting Data / Individual Contracts
2 participants
@LouisSzeto @AlexCatarino