Breaking tps api? #1069
Replies: 1 comment 1 reply
-
You caught me. My entire motive was to break plugins. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
https://github.com/PurpurMC/Purpur/blob/ver/1.19/patches/server/0067-Add-5-second-tps-average-in-tps.patch
can't this make plugins show incorrect tps, when they hard code that in index 0 is 1 minute tps, in 1 is 5 minutes etc. ?
Purpur/patches/server/0067-Add-5-second-tps-average-in-tps.patch
Line 79 in 028780d
this for sure looks like made to break plugins, very strange changes in api, where plugins can't check that index 1 is now desired tps instead of 0 etc.
is this really safe? shouldn't in api at least it be a separate call (like get5STps()) where plugins that would like to use 5 could use, and plugins which expect at index 0 to be 1 minute average, get 1 minute average?
maybe you know better these changes and could explain better
Beta Was this translation helpful? Give feedback.
All reactions