New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete types.js #1

Open

rom1504 opened this issue Jun 22, 2017 · 5 comments

Member

rom1504 commented Jun 22, 2017

try to reuse https://github.com/ProtoDef-io/node-protodef/tree/master/src/datatypes

ghost commented Jun 22, 2017

#3, we also need a test to check to make sure all the types work properly

Member Author

rom1504 commented Jul 27, 2017

still lot of types missing

Member Author

rom1504 commented Jul 27, 2017 •

edited

Loading

partial read error for all the reader : have https://github.com/ProtoDef-io/node-protodefc/blob/master/lib/types/numeric.js#L52 everywhere else
have same interface than node-protodef to use existing native functions : see https://github.com/ProtoDef-io/node-protodefc/blob/master/lib/types/utils.js#L55 vs https://github.com/ProtoDef-io/node-protodef/blob/master/src/datatypes/utils.js#L135 : will be useful to reuse native types in nmp https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/datatypes/minecraft.js

Member Author

rom1504 commented Jul 28, 2017

related ProtoDef-io/protodefc#13

Member Author

rom1504 commented Jul 28, 2017

I guess a temporary solution would be copy/pasting nmp stuff and fixing it to use protodefc interface.

At least we would know whether it works / is fast.

My problem with that is compatibility with node-protodef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment