Zi temperature dependent and normalizations #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orso82
changed the title
|
Tested this for all three cases - Hirshman Sigmar, Chang Hinton and the full NEO. Other than a couple of minor bugs in the full NEO case that I pushed a fix for already, the answers come out with only negligible differences from what they were before. I approve! |
|
thanks @adrianaghiozzi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR of ProjectTorreyPines/TGLFNN.jl#20
Also for this one, can you please double and triple check my changes?
@adrianaghiozzi I don't have NEO installed on my laptop, can you try running it on yours?