Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Modernize game-specific protocol extensions #82

Open
1 task done
ItzSwirlz opened this issue Jul 29, 2024 · 1 comment
Open
1 task done

[Enhancement]: Modernize game-specific protocol extensions #82

ItzSwirlz opened this issue Jul 29, 2024 · 1 comment
Labels
awaiting-approval Topic has not been approved or denied enhancement An update to an existing part of the codebase

Comments

@ItzSwirlz
Copy link
Contributor

Checked Existing

  • I have checked the repository for duplicate issues.

What enhancement would you like to see?

Some game server protocol extensions (for example, Splatoon), are not as modernized with the rest of the codebase.

For example, creating a Ranking protocol is normally handled like this:

func NewProtocol() *Protocol {
	return &Protocol{}
}

However, the Splatoon ranking protocol extension still requires the protocol to be made with the endpoint:

// NewProtocol returns a new RankingSplatoon protocol
func NewProtocol(endpoint nex.EndpointInterface) *Protocol {
	protocol := &Protocol{endpoint: endpoint}
	protocol.rankingProtocol.SetEndpoint(endpoint)

	return protocol
}

Mario Kart 8's ranking also has this:

// NewProtocol returns a new RankingMarioKart8 protocol
func NewProtocol(endpoint nex.EndpointInterface) *Protocol {
	protocol := &Protocol{endpoint: endpoint}
	protocol.rankingProtocol.SetEndpoint(endpoint)

	return protocol
}

The game-specific protocol extensions should be updated for consistency.

Any other details to share? (OPTIONAL)

No response

@ItzSwirlz ItzSwirlz added awaiting-approval Topic has not been approved or denied enhancement An update to an existing part of the codebase labels Jul 29, 2024
@ItzSwirlz
Copy link
Contributor Author

I should mention that Jon said that he wants game-specific protocols to be moved out of this library though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Topic has not been approved or denied enhancement An update to an existing part of the codebase
Projects
None yet
Development

No branches or pull requests

1 participant