Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression]: Reaction remove logs causes consistent crashes #47

Open
1 task done
jonbarrow opened this issue Oct 18, 2024 · 0 comments
Open
1 task done

[Regression]: Reaction remove logs causes consistent crashes #47

jonbarrow opened this issue Oct 18, 2024 · 0 comments
Labels
approved The topic is approved by a developer regression A previously working feature has broken

Comments

@jonbarrow
Copy link
Member

Checked Existing

  • I have checked the repository for duplicate issues.

What happened?

In reactionRemoveHandler if messageAuditRelationship does not exist then it tries to create a thread and send a log message there. However the thread is not checked for being null or undefined and thus causes crashes if it is.

Why was this functionality added? What purpose does logging the removal of reactions have?

What was the previous functionality?

There was no reaction remove logs

When did this occur?

The reaction logs system was added in #29

Other relevant information. (OPTIONAL)

The stacktrace when the crash happens is:

node:events:497
      throw er; // Unhandled 'error' event
      ^
TypeError: Cannot read properties of null (reading 'send')
    at Client.reactionRemoveHandler (/home/jonbarrow/Chubby/dist/events/reactionRemove.js:39:22)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
Emitted 'error' event on Client instance at:
    at emitUnhandledRejectionOrErr (node:events:402:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:84:21)
@jonbarrow jonbarrow added awaiting-approval Topic has not been approved or denied regression A previously working feature has broken approved The topic is approved by a developer and removed awaiting-approval Topic has not been approved or denied labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The topic is approved by a developer regression A previously working feature has broken
Projects
Status: Todo
Development

No branches or pull requests

1 participant