-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModuleNotFoundError when importing skops after import prefect (prefect 3) #15739
Labels
bug
Something isn't working
Comments
protagonyist
pushed a commit
to protagonyist/prefect
that referenced
this issue
Oct 17, 2024
protagonyist
added a commit
to protagonyist/prefect
that referenced
this issue
Oct 17, 2024
protagonyist
added a commit
to protagonyist/prefect
that referenced
this issue
Oct 17, 2024
4 tasks
4 tasks
protagonyist
added a commit
to protagonyist/prefect
that referenced
this issue
Oct 18, 2024
protagonyist
added a commit
to protagonyist/prefect
that referenced
this issue
Oct 18, 2024
protagonyist
added a commit
to protagonyist/prefect
that referenced
this issue
Oct 20, 2024
protagonyist
added a commit
to protagonyist/prefect
that referenced
this issue
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug summary
Recently, I was working on upgrading project to prefect 3. That project uses skops for safe storing and loading ML models. Following imports (prefect==3.0.10, skops==0.10):
Cause exception:
code to reproduce:
After some investigation, I figured that
__getattr__
function (that was added for lazy imports in #14190) throws ModuleNotFoundErorr in case when regular python modules throw AttributeError (and because of that, skops does not catch it while inspecting imported modules):I already prepared fix (here), but contribution guideline suggests that I create issue first, so here it is
P. S. I still feel a bit insecure writing in English, sorry about any mistakes
Version info (
prefect version
output)Additional context
No response
The text was updated successfully, but these errors were encountered: