Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lowercase log level for uvicorn.run in runner webserver #15734

Closed
wants to merge 1 commit into from
Closed

lowercase log level for uvicorn.run in runner webserver #15734

wants to merge 1 commit into from
+3 −1

Conversation

zzstoatzz
Copy link
Collaborator

@zzstoatzz zzstoatzz commented Oct 17, 2024 •
edited
Loading

@zzstoatzz zzstoatzz added the fix A fix for a bug in an existing feature label Oct 17, 2024
@github-actions github-actions bot added the bug Something isn't working label Oct 17, 2024
@zzstoatzz zzstoatzz changed the title lowercase log level lowercase log level for uvicorn.run in runner webserver Oct 17, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #15734 will not alter performance

Comparing lower-log-level-serve-webserver (35b1339) with main (3500c2f)

Summary

✅ 3 untouched benchmarks

@desertaxle
Copy link
Member

FYI, it looks like this is a duplicate of #15680

@zzstoatzz zzstoatzz closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

Assignees
No one assigned
Labels
bug Something isn't working fix A fix for a bug in an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fails to run jobs if serving with webserver=True
2 participants
@zzstoatzz @desertaxle