Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes max-active-runs and catchup #15663

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Removes max-active-runs and catchup #15663

wants to merge 4 commits into from
+8 −334

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Oct 11, 2024

Closes #15661

@github-actions github-actions bot added the bug Something isn't working label Oct 11, 2024
zzstoatzz
zzstoatzz reviewed Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@zzstoatzz zzstoatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we have a stray file, but otherwise this lgtm

prefect-ui/src/routes/flows/flow.$id.tsx Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume this one was cruft from elsewhere?

@zzstoatzz zzstoatzz added the development Tech debt, refactors, CI, tests, and other related work. label Oct 11, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 14, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #15663 will not alter performance

Comparing adam/oss-5758-remove-max-active-runs-and-catchup (53ba448) with main (0eecd59)

Summary

✅ 3 untouched benchmarks

@zzstoatzz zzstoatzz force-pushed the adam/oss-5758-remove-max-active-runs-and-catchup branch from b7acc78 to cb133a9 Compare October 16, 2024 19:43
@github-actions github-actions bot added the docs label Oct 16, 2024
@zzstoatzz zzstoatzz force-pushed the adam/oss-5758-remove-max-active-runs-and-catchup branch from 52fe4ba to 53ba448 Compare October 17, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzstoatzz zzstoatzz zzstoatzz left review comments

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@discdiver discdiver Awaiting requested review from discdiver discdiver is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working development Tech debt, refactors, CI, tests, and other related work. docs migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove max-active-runs and catchup
2 participants
@aaazzam @zzstoatzz