Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max-active-runs and catchup #15661

Open
aaazzam opened this issue Oct 11, 2024 · 0 comments · May be fixed by #15663
Open

Remove max-active-runs and catchup #15661

aaazzam opened this issue Oct 11, 2024 · 0 comments · May be fixed by #15663
Assignees
Labels
bug Something isn't working

Comments

@aaazzam
Copy link
Collaborator

aaazzam commented Oct 11, 2024

Bug summary

The deployment keywords max_active_runs: int and catchup: bool were part of an old API design for deployment concurrency that was never implemented. We have since opted for a different design, but these kwargs still exist throughout the codebase. This is causing several issues:

  • Polluting the API surface
  • Creating confusion in the documentation
  • Potentially misleading developers about available functionality

Version info (prefect version output)

Version:             3.0.9.dev1
API version:         0.8.4
Python version:      3.12.4
Git commit:          e8cd03b3
Built:               Thu, Oct 10, 2024 4:35 PM
OS/Arch:             darwin/arm64
Profile:             local
Server type:         server
Pydantic version:    2.8.2

Additional context

No response

@aaazzam aaazzam added the bug Something isn't working label Oct 11, 2024
@aaazzam aaazzam linked a pull request Oct 11, 2024 that will close this issue
@aaazzam aaazzam self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant