Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeepMerge.deep_merge/3 has invalid spec #12

Open
thomas9911 opened this issue Jul 14, 2020 · 1 comment
Open

DeepMerge.deep_merge/3 has invalid spec #12

thomas9911 opened this issue Jul 14, 2020 · 1 comment

Comments

@thomas9911
Copy link

The spec says that the third argument should be a function with arity two but the examples and in the code a function with arity 3 is used.

current:

@spec deep_merge(map() | keyword(), map() | keyword(), (any(), any() -> any())) :: map() | keyword()

expected:

@spec deep_merge(map() | keyword(), map() | keyword(), (any(), any(), any() -> any())) :: map() | keyword()
@dsnipe
Copy link

dsnipe commented Dec 1, 2022

@PragTob Hey, you made a very useful library, but this dialyzer error just doesn't allow me to use it in my project (CI uses dilyzer, so there must be no errors)
Any update on this? I can open a PR, if you are ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants