Initialize properties map when sending feature flags #26
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When capturing an event with SendFeatureFlags set to true and no
properties defined posthog panics with nil pointer.
Panic:
```
github.com/posthog/posthog-go.(*client).Enqueue(0x4000abba00, {0x420b130?, 0x40015705a0?)
/root/go/pkg/mod/github.com/posthog/[email protected]/posthog.go:194
```
Example:
```go
client.Enqueue(posthog.Capture{
DistinctId: user.ID,
Event: "test_event",
SendFeatureFlags: true,
})
```
neilkakkar
reviewed
Jan 15, 2024
| @@ -189,6 +189,11 @@ func (c *client) Enqueue(msg Message) (err error) { | |||
| if err != nil { | |||
| c.Errorf("unable to get feature variants - %s", err) | |||
| } | |||
|
|
|||
| if m.Properties == nil { | |||
There was a problem hiding this comment.
great catch, thanks @zaynetro , could you please also add a testcase for sendFeatureFlags in capture?
|
lovely, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When capturing an event with SendFeatureFlags set to true and no properties defined posthog panics with nil pointer.
Panic:
Example: